[scan-build][Windows] Fix driver name transformation in scan-build #143135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
kikairoya
changed the title
On Windows system, scan-build resolves clang++ driver name as "clang-{ver}++.exe"
from "clang-{ver}.exe" but should transform to "clang++.exe".
Member
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-static-analyzer-1 Author: Tomohiro Kashiwada (kikairoya) ChangesOn Windows system, scan-build resolves clang++ driver name as "clang-{ver}++.exe" from "clang-{ver}.exe" but should transform to "clang++.exe". Full diff: https://github.com/llvm/llvm-project/pull/143135.diff 1 Files Affected:
diff --git a/clang/tools/scan-build/bin/scan-build b/clang/tools/scan-build/bin/scan-build
index b90e635d31757..da7fe94cf4c03 100755
--- a/clang/tools/scan-build/bin/scan-build
+++ b/clang/tools/scan-build/bin/scan-build
@@ -1898,7 +1898,7 @@ if ($Clang !~ /\+\+(\.exe)?$/) {
# Determine operating system under which this copy of Perl was built.
my $IsWinBuild = ($^O =~/msys|cygwin|MSWin32/);
if($IsWinBuild) {
- $ClangCXX =~ s/.exe$/++.exe/;
+ $ClangCXX =~ s/\-\d+(\.\d+)?.exe$/++.exe/;
}
else {
$ClangCXX =~ s/\-\d+(\.\d+)?$//;
|
kikairoya
force-pushed
the
scanbuild-windows
branch
from
206a121 to
7d6d268
Compare
steakhal
approved these changes
Jun 6, 2025
Contributor
steakhal
left a comment
steakhal
left a comment
There was a problem hiding this comment.
I've never used scan-build on Windows, but the patch looks harmless so let's fix this.
steakhal
changed the title
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
…lvm#143135) On Windows system, scan-build resolves clang++ driver name as "clang-{ver}++.exe" from "clang-{ver}.exe" but should transform to "clang++.exe".
jeremyd2019
pushed a commit
to jeremyd2019/llvm-project
that referenced
this pull request
Aug 9, 2025
…lvm#143135) On Windows system, scan-build resolves clang++ driver name as "clang-{ver}++.exe" from "clang-{ver}.exe" but should transform to "clang++.exe".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows system, scan-build resolves clang++ driver name as "clang-{ver}++.exe" from "clang-{ver}.exe" but should transform to "clang++.exe".